Use dataset instead of attribute functions

Usbac · Apr 6, 2024 · 19247f8 · 19247f8
1 parent 8e3a5fe
commit 19247f8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/app/views/admin/settings.php b/app/views/admin/settings.php
@@ -273,8 +273,8 @@ function update() {
                 ? 'initial'
                 : 'none');
             document.querySelectorAll('.tabs > a').forEach(el => el.getAttribute('href') == location.hash
-                ? el.setAttribute('data-checked', true)
-                : el.removeAttribute('data-checked'));
+                ? el.dataset.checked = true
+                : delete el.dataset.checked);
         });
 
         window.addEventListener('load', () => {

diff --git a/public/assets/css/admin/main.css b/public/assets/css/admin/main.css
@@ -706,7 +706,7 @@ textarea.code {
     display: none;
 }
 
-#snackbar[show] {
+#snackbar[data-show] {
     top: 20px;
 }
 
@@ -1158,7 +1158,7 @@ textarea.code {
     overflow: hidden;
 }
 
-.dropdown-menu[active] {
+.dropdown-menu[data-active] {
     display: flex;
 }
 

diff --git a/public/assets/js/admin.js b/public/assets/js/admin.js
@@ -48,14 +48,14 @@ class Snackbar {
         }
 
         get('#snackbar > span').innerHTML = msg;
-        snackbar.setAttribute('show', true);
+        snackbar.dataset.show = true;
         this.#timeout = setTimeout(() => this.hide(), 5000);
     }
 
     static hide() {
         let snackbar = get('#snackbar');
         clearTimeout(this.#timeout);
-        snackbar.removeAttribute('show');
+        delete snackbar.dataset.show;
         setTimeout(() => snackbar.classList.remove('error'), 200);
     }
 }
@@ -285,7 +285,7 @@ class Dropdown {
             this.#active_dropdown = dropdown;
 
             if (this.#active_dropdown) {
-                this.#active_dropdown.setAttribute('active', true);
+                this.#active_dropdown.dataset.active = true;
                 this.#active_dropdown.original_btn = dropdown_btn;
                 document.body.appendChild(this.#active_dropdown);
                 updateActiveDropdown();
@@ -295,7 +295,7 @@ class Dropdown {
 
     static close() {
         if (this.#active_dropdown) {
-            this.#active_dropdown.removeAttribute('active');
+            delete this.#active_dropdown.dataset.active;
             this.#active_dropdown.original_btn.appendChild(this.#active_dropdown);
         }
     }