fix(agent): ensure algolia agent is not duplicated by successive calls

Yamsafer · Jan 4, 2017 · 77b9762 · 77b9762
1 parent fa1d10f
commit 77b9762
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/AlgoliaSearchCore.js b/src/AlgoliaSearchCore.js
@@ -154,7 +154,9 @@ AlgoliaSearchCore.prototype.setExtraHeader = function(name, value) {
 * @param algoliaAgent the agent to add
 */
 AlgoliaSearchCore.prototype.addAlgoliaAgent = function(algoliaAgent) {
-  this._ua += ';' + algoliaAgent;
+  if (this._ua.indexOf(';' + algoliaAgent) === -1) {
+    this._ua += ';' + algoliaAgent;
+  }
 };
 
 /*

diff --git a/test/spec/common/client/addAlgoliaAgent.js b/test/spec/common/client/addAlgoliaAgent.js
@@ -16,6 +16,10 @@ test('client.addAlgoliaAgent(algoliaAgent)', function(t) {
   var index = fixture.index;
 
   client.addAlgoliaAgent('And some other incredible agent');
+
+  // Ensure we de-duplicate by re-adding the same agent a second time.
+  client.addAlgoliaAgent('And some other incredible agent');
+
   index.search('algolia agent');
 
   var expectedAgent = fixture.algoliasearch.ua + ';And some other incredible agent';