Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 20250116 #3290

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Refactor 20250116 #3290

merged 3 commits into from
Jan 16, 2025

Conversation

wenshao
Copy link
Member

@wenshao wenshao commented Jan 16, 2025

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@wenshao wenshao merged commit 23eb651 into main Jan 16, 2025
28 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.97872% with 72 lines in your changes missing coverage. Please review.

Project coverage is 72.74%. Comparing base (eb28d51) to head (6913ae6).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/com/alibaba/fastjson2/JSONReaderJSONB.java 79.92% 14 Missing and 40 partials ⚠️
...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java 88.11% 13 Missing and 4 partials ⚠️
...ore/src/main/java/com/alibaba/fastjson2/JSONB.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3290      +/-   ##
============================================
- Coverage     74.29%   72.74%   -1.55%     
+ Complexity    23451    22730     -721     
============================================
  Files           668      668              
  Lines         89915    89301     -614     
  Branches      20337    20175     -162     
============================================
- Hits          66798    64964    -1834     
- Misses        14932    16042    +1110     
- Partials       8185     8295     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants