Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adding content in Create a PR section #468

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

clatapie
Copy link
Contributor

This PR specifies how to properly set up a PR when creating one.
It refers to this PyMAPDL discussion.

@clatapie clatapie requested review from germa89 and RobPasMue June 17, 2024 15:13
@clatapie clatapie self-assigned this Jun 17, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 17, 2024
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

clatapie and others added 2 commits June 17, 2024 17:24
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@clatapie clatapie merged commit b0e58fb into main Jun 17, 2024
13 checks passed
@clatapie clatapie deleted the doc/adding_content_in_create_a_PR_section branch June 17, 2024 15:29
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
* doc: adding content in `Create a PR` section

* Apply suggestions from code review

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

---------

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants