-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing memory limitations in dockerizer jobs #2483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
CI/CD
Related with CICD, Github Actions, etc
Maintenance
labels
Nov 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #2483 +/- ##
==========================================
- Coverage 83.94% 83.83% -0.11%
==========================================
Files 44 44
Lines 8675 8675
==========================================
- Hits 7282 7273 -9
- Misses 1393 1402 +9 |
koubaa
approved these changes
Nov 8, 2023
clatapie
added a commit
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title
Recent discussion in here #2479, led me to think that limiting the amount of memory used by docker container can improve its stability.
Therefore I'm limiting the amount of memory (
--memory
) to 6.5GB of RAM, and the amount of swap (--memory-swap
) to the RAM (6.5GB) plus 10GB of the 14GB of the SSD memory (16.5GB).I am also disabling out-of-memory killing (
--oom-kill-disable
) so the container will use all the memory available without being killed. Probably it wont be needed if memory is limited.References: