Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes #2523

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Small changes #2523

merged 4 commits into from
Nov 22, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 22, 2023

  • Adding missing goto in make.bat
  • Fixing doc reference to pool.
  • Renaming codecov reference.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 22, 2023
@germa89 germa89 requested a review from clatapie November 22, 2023 19:29
@germa89 germa89 enabled auto-merge (squash) November 22, 2023 19:33
@germa89
Copy link
Collaborator Author

germa89 commented Nov 22, 2023

LGTM

pyansys-ci-bot
pyansys-ci-bot approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Merging #2523 (642192d) into main (df48beb) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2523      +/-   ##
==========================================
- Coverage   83.90%   83.89%   -0.02%     
==========================================
  Files          44       44              
  Lines        8755     8755              
==========================================
- Hits         7346     7345       -1     
- Misses       1409     1410       +1

@germa89 germa89 merged commit 6b6d3ce into main Nov 22, 2023
23 checks passed
@germa89 germa89 deleted the fix/vale-complains branch November 22, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @pyansys-ci-bot