Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Requirement: pyvista >= 0.38.1 #2534

Closed
wants to merge 4 commits into from
Closed

Bump Requirement: pyvista >= 0.38.1 #2534

wants to merge 4 commits into from

Conversation

beppo-dd
Copy link
Contributor

This should solve #2500.

To be very safe, someone should check the builded package.

beppo-dd and others added 4 commits November 10, 2023 18:22
Before in the project meta data pyproject.toml under dependencies there is
the requirement `pyvista>=0.33.0`, see pyproject.toml, line 38.
But, this old version 0.33.0 lacks the function pyvista.plotting.colors.get_cycler
which ansys.mapdl.core.theme, line 16 wants to import. This functions was
just introduced in pyvista 0.38.1 with pull #3739, see definition of
get_cycler in the corresponding diff.
As this is still used in three locations in GitHub workflows.
@beppo-dd beppo-dd requested a review from a team as a code owner November 24, 2023 23:02
@beppo-dd beppo-dd requested review from germa89 and clatapie November 24, 2023 23:02
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@beppo-dd beppo-dd closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants