#2500 Bump Requirement: pyvista >= 0.38.1 #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before in the project meta data pyproject.toml under dependencies there is the requirement `pyvista>=0.33.0`, see pyproject.toml, line 38. But, this old version 0.33.0 lacks the function pyvista.plotting.colors.get_cycler which ansys.mapdl.core.theme, line 16 wants to import. This functions was just introduced in pyvista 0.38.1 with pull #3739, see definition of get_cycler in the corresponding diff. Bump pyvista >= 0.38.1 also for .ci\requirements_test_xvfb.txt As this is still used in three locations in GitHub workflows.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
|
Hi @beppo-dd I think I wasn't clear enough in my previous message... You should not be working from a forked repository. Since you have been added as collaborator, now you can clone the pymapdl repository itself and do PRs directly there. Without using your fork. I feel very bad you need to close and reopen this PR. So I will go ahead and just merge. Again, thank you a lot for your contribution and I hope this CICD quirks do not discourage you to keep contributing to PyMAPDL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before in the project meta data pyproject.toml under dependencies there is the requirement
pyvista>=0.33.0, see pyproject.toml, line 38. But, this old version 0.33.0 lacks the function pyvista.plotting.colors.get_cycler which ansys.mapdl.core.theme, line 16 wants to import. This functions was just introduced in pyvista 0.38.1 with pull #3739, see definition of get_cycler in the corresponding diff.Bump pyvista >= 0.38.1 also for .ci\requirements_test_xvfb.txt As this is still used in three locations in GitHub workflows.
This should solve #2500.
To be very safe, someone should check the builded package.