Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a warning if there is a conflict between env vars and arguments #2913

Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 19, 2024

As the title.

To be merged to main after #2912

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested a review from koubaa March 19, 2024 12:49
@germa89 germa89 self-assigned this Mar 19, 2024
@germa89 germa89 added the DO NOT MERGE Not ready to be merged yet label Mar 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (ba6d8fe) to head (745cf7f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2913      +/-   ##
==========================================
- Coverage   86.59%   84.71%   -1.88%     
==========================================
  Files          48       48              
  Lines        9449     9459      +10     
==========================================
- Hits         8182     8013     -169     
- Misses       1267     1446     +179     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/ansys/mapdl/core/launcher.py Show resolved Hide resolved
Base automatically changed from fix/start-instance-argument-being-silently-overwritting to main March 20, 2024 09:25
germa89 and others added 2 commits March 20, 2024 10:27
Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
@wiz-inc-572fc38784
Copy link
Contributor

wiz-inc-572fc38784 bot commented Mar 20, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@germa89 germa89 enabled auto-merge (squash) March 20, 2024 09:27
@germa89 germa89 merged commit c97a275 into main Mar 20, 2024
27 checks passed
@germa89 germa89 deleted the feat/adding-exception-if-attempting-to-overwrite-envvar-behaviour branch March 20, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Not ready to be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants