Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring PYMAPDL_START_INSTANCE env var on CLI pymapdl start #2915

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 19, 2024

As the title.

Close #2914

@germa89 germa89 added the BUG label Mar 19, 2024
@germa89 germa89 requested a review from clatapie March 19, 2024 19:54
@germa89 germa89 self-assigned this Mar 19, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 64.82%. Comparing base (ea42836) to head (0056c89).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2915       +/-   ##
===========================================
- Coverage   86.59%   64.82%   -21.77%     
===========================================
  Files          48       48               
  Lines        9449     9451        +2     
===========================================
- Hits         8182     6127     -2055     
- Misses       1267     3324     +2057     

@germa89 germa89 enabled auto-merge (squash) March 20, 2024 09:25
@wiz-inc-572fc38784
Copy link
Contributor

wiz-inc-572fc38784 bot commented Mar 20, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 2780f04 into main Mar 20, 2024
30 checks passed
@germa89 germa89 deleted the fix/ignoring-pymapdl_start_instance-on-the-cli branch March 20, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to open a PyMAPDL instance
3 participants