Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding inputs and outputs #3112

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 21, 2024

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this May 21, 2024
@germa89 germa89 requested a review from koubaa May 21, 2024 08:42
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 3.26087% with 89 lines in your changes are missing coverage. Please review.

Project coverage is 82.11%. Comparing base (33ac15a) to head (d7b5918).

Current head d7b5918 differs from pull request most recent head 313f1dc

Please upload reports for the commit 313f1dc to get more accurate results.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/pyhps-support    #3112      +/-   ##
======================================================
- Coverage               82.65%   82.11%   -0.54%     
======================================================
  Files                      54       54              
  Lines                    9766     9832      +66     
======================================================
+ Hits                     8072     8074       +2     
- Misses                   1694     1758      +64     

@germa89 germa89 mentioned this pull request May 21, 2024
@germa89 germa89 marked this pull request as draft May 21, 2024 08:48
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89
Copy link
Collaborator Author

germa89 commented May 22, 2024

Merging because this will review all together when merging #3091

@pyansys-ci-bot LTGM.

@germa89 germa89 marked this pull request as ready for review May 22, 2024 09:46
@germa89 germa89 merged commit 4055c60 into feat/pyhps-support May 22, 2024
24 of 25 checks passed
@germa89 germa89 deleted the feat/adding-input-and-outputs branch May 22, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants