-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Detaching logging from main logic #3205
feat: Detaching logging from main logic #3205
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
…ub.com/ansys/pymapdl into feat/detaching-logging-from-main-logic
Allowing login using token which is now the preferred method.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/pyhps-support #3205 +/- ##
======================================================
- Coverage 79.82% 77.96% -1.86%
======================================================
Files 55 57 +2
Lines 10200 10406 +206
======================================================
- Hits 8142 8113 -29
- Misses 2058 2293 +235 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I do want to see an "example usage" section, even if its just a docstring
…://github.com/ansys/pymapdl into feat/detaching-logging-from-main-logic
Description
Login should be handled separately, and having its own command line like
docker login
.Issue linked
NA
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)