Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detaching logging from main logic #3205

Merged
merged 19 commits into from
Jun 26, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 24, 2024

Description

Login should be handled separately, and having its own command line like docker login.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner June 24, 2024 15:20
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team June 24, 2024 15:20
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jun 24, 2024
@germa89 germa89 marked this pull request as draft June 24, 2024 15:44
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) dependencies maintenance General maintenance of the repo (libraries, cicd, etc) enhancement Improve any current implemented feature new feature Request or proposal for a new feature labels Jun 24, 2024
@github-actions github-actions bot removed the CI/CD Related with CICD, Github Actions, etc label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 2.72727% with 214 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (dd0cb4b) to head (9818a16).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/pyhps-support    #3205      +/-   ##
======================================================
- Coverage               79.82%   77.96%   -1.86%     
======================================================
  Files                      55       57       +2     
  Lines                   10200    10406     +206     
======================================================
- Hits                     8142     8113      -29     
- Misses                   2058     2293     +235     

Copy link
Contributor

@koubaa koubaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I do want to see an "example usage" section, even if its just a docstring

@germa89 germa89 requested a review from koubaa June 26, 2024 15:07
@germa89 germa89 marked this pull request as ready for review June 26, 2024 15:07
@germa89 germa89 merged commit 4145688 into feat/pyhps-support Jun 26, 2024
40 of 44 checks passed
@germa89 germa89 deleted the feat/detaching-logging-from-main-logic branch June 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc) new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants