Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moving tests to a class and adding delete method. #3258

Merged
merged 8 commits into from
Jul 16, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 9, 2024

Description

Moving pool tests to a class. The idea is to make sure we leave no instances behind.

Issue linked

Related to #3254

Checklist

@germa89 germa89 requested a review from a team as a code owner July 9, 2024 12:34
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 9, 2024 12:34
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jul 9, 2024
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (03f722e) to head (9dfd750).
Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (03f722e) and HEAD (9dfd750). Click for more details.

HEAD has 84 uploads less than BASE
Flag BASE (03f722e) HEAD (9dfd750)
dmp 17 6
minimal 7 3
ubuntu 21 9
local 14 6
non-student 16 0
smp 8 3
remote 11 3
v23.2-ubuntu 3 0
v24.1-ubuntu 3 0
centos 4 0
v24.2.0 1 0
v24.2-ubuntu 3 0
latest-ubuntu 3 0
v24.1.0 1 0
v25.1.0 1 0
v23.1.0 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3258      +/-   ##
==========================================
- Coverage   88.22%   83.06%   -5.16%     
==========================================
  Files          53       55       +2     
  Lines        9670     9753      +83     
==========================================
- Hits         8531     8101     -430     
- Misses       1139     1652     +513     

@germa89
Copy link
Collaborator Author

germa89 commented Jul 16, 2024

@clatapie please review :)

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@germa89 germa89 merged commit 6de31cc into main Jul 16, 2024
50 checks passed
@germa89 germa89 deleted the test/moving-pool-tests-to-a-class branch July 16, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants