-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: moving tests to a class and adding delete method. #3258
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
==========================================
- Coverage 88.22% 83.06% -5.16%
==========================================
Files 53 55 +2
Lines 9670 9753 +83
==========================================
- Hits 8531 8101 -430
- Misses 1139 1652 +513 |
@clatapie please review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
Moving pool tests to a class. The idea is to make sure we leave no instances behind.
Issue linked
Related to #3254
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)