Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing arguments in secdata #3295

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 18, 2024

Description

Fix missing arguments in SECDATA.

Issue linked

Close #3278

Checklist

@germa89 germa89 requested a review from a team as a code owner July 18, 2024 08:48
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 18, 2024 08:48
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.15%. Comparing base (81d8afd) to head (4d2081a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3295      +/-   ##
==========================================
+ Coverage   87.13%   87.15%   +0.02%     
==========================================
  Files          55       55              
  Lines        9768     9768              
==========================================
+ Hits         8511     8513       +2     
+ Misses       1257     1255       -2     

@germa89 germa89 enabled auto-merge (squash) July 18, 2024 09:11
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 08b6f36 into main Jul 18, 2024
66 checks passed
@germa89 germa89 deleted the fix/missing-values-in-secdata branch July 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SECDATA and ASEC Beams
3 participants