Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Making sure we skip all the pool unit tests. #3315

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 29, 2024

Description

Some pool tests weren't properly skip.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner July 29, 2024 13:59
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team and clatapie July 29, 2024 13:59
@germa89 germa89 self-assigned this Jul 29, 2024
@germa89 germa89 requested review from dts12263 and removed request for pyansys-ci-bot July 29, 2024 13:59
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jul 29, 2024
@germa89 germa89 requested a review from clatapie July 29, 2024 14:00
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (d50f95c) to head (1397949).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3315      +/-   ##
==========================================
- Coverage   87.15%   85.92%   -1.24%     
==========================================
  Files          55       55              
  Lines        9768     9773       +5     
==========================================
- Hits         8513     8397     -116     
- Misses       1255     1376     +121     

@germa89 germa89 enabled auto-merge (squash) July 29, 2024 14:17
@germa89 germa89 merged commit f186e30 into main Jul 29, 2024
60 checks passed
@germa89 germa89 deleted the fix/reorg-skip-pool-tests branch July 29, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants