-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding python side retry mechanism #3354
Conversation
…ited function more broadly.
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your implementation seems fine, I just left a minor comment.
…s://github.com/ansys/pymapdl into feat/adding-python-side-retry-mechanism
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3354 +/- ##
==========================================
+ Coverage 87.13% 87.41% +0.27%
==========================================
Files 55 55
Lines 9816 9843 +27
==========================================
+ Hits 8553 8604 +51
+ Misses 1263 1239 -24 |
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exception messages are now very clear:
|
@PipKat can you spot any issues here (surely there are!) ?
|
There are issues with CICD, taking forever to finish ... 75 minutes. It seems it gets stuck after runing this test. |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache in a new commit. This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Description
Add a retry mechanism in Python. We are assuming, that because of network issues, one call didn't reach the MAPDL instance. Hence, we can try again safely.
My concern is to trigger twice long calls (
SOLVE
).Issue linked
Related to #3342
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)