Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reuploading file on CDREAD #3355

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 14, 2024

Description

Check if input is called from CDREAD, if it is, it does not upload the file again.

Issue linked

Close #3348

Checklist

@germa89 germa89 requested a review from a team as a code owner August 14, 2024 17:08
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team August 14, 2024 17:08
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Aug 14, 2024
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Aug 14, 2024
@github-actions github-actions bot added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.12%. Comparing base (f21aac9) to head (0cfcf1e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3355      +/-   ##
==========================================
- Coverage   87.12%   87.12%   -0.01%     
==========================================
  Files          55       55              
  Lines        9813     9816       +3     
==========================================
+ Hits         8550     8552       +2     
- Misses       1263     1264       +1     

@germa89 germa89 enabled auto-merge (squash) August 20, 2024 17:08
@germa89
Copy link
Collaborator Author

germa89 commented Aug 20, 2024

@pyansys-ci-bot LGTM.

@github-actions github-actions bot removed dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Aug 20, 2024
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 93dd176 into main Aug 20, 2024
59 checks passed
@germa89 germa89 deleted the fix/uploading-files-double-in-CDREAD branch August 20, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDREAD upload files if they exists in the MAPDL working directory
2 participants