Update conftest.py to switch mapdl.tbdat to mapdl.tbdata #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing newly added mapdl.tbdat to mapdl.tbdata to fix the following [ERROR] TestFieldComponentValueGetter.test_temp - E AttributeError: 'MapdlGrpc' object has no attribute 'tbdat' [ERROR] TestFieldComponentValueGetter.test_pressure - E AttributeError: 'MapdlGrpc' object has no attribute 'tbdat' [ERROR] TestFieldComponentValueGetter.test_volt - E AttributeError: 'MapdlGrpc' object has no attribute 'tbdat' [ERROR] TestFieldComponentValueGetter.test_mag - E AttributeError: 'MapdlGrpc' object has no attribute 'tbdat'
dts12263
requested review from
germa89 and
clatapie
and removed request for
a team
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
|
@pyansys-ci-bot LGTM. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3362 +/- ##
==========================================
- Coverage 87.13% 87.12% -0.02%
==========================================
Files 55 55
Lines 9813 9813
==========================================
- Hits 8551 8550 -1
- Misses 1262 1263 +1 |
germa89
approved these changes
Aug 19, 2024
|
thank you a lot @dts12263 ! |
btw, you haven't been authorized yet.... but this comment will trigger |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing newly added mapdl.tbdat to mapdl.tbdata to fix the following
[ERROR] TestFieldComponentValueGetter.test_temp - E AttributeError: 'MapdlGrpc' object has no attribute 'tbdat'
[ERROR] TestFieldComponentValueGetter.test_pressure - E AttributeError: 'MapdlGrpc' object has no attribute 'tbdat'
[ERROR] TestFieldComponentValueGetter.test_volt - E AttributeError: 'MapdlGrpc' object has no attribute 'tbdat'
[ERROR] TestFieldComponentValueGetter.test_mag - E AttributeError: 'MapdlGrpc' object has no attribute 'tbdat'
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)