Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip database testing on v23.X #3384

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 2, 2024

Description

Deactivate database tests on v23.X.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner September 2, 2024 12:32
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team September 2, 2024 12:32
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Sep 2, 2024
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.08%. Comparing base (08c48c7) to head (1d0a5bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3384      +/-   ##
==========================================
- Coverage   87.30%   85.08%   -2.22%     
==========================================
  Files          55       55              
  Lines        9926     9926              
==========================================
- Hits         8666     8446     -220     
- Misses       1260     1480     +220     

@germa89 germa89 enabled auto-merge (squash) September 3, 2024 08:59
@germa89
Copy link
Collaborator Author

germa89 commented Sep 3, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit e25dddf into main Sep 3, 2024
63 of 64 checks passed
@germa89 germa89 deleted the chore/skip-database-tests-on-v23.X branch September 3, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants