Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: python version warning #3570

Merged
merged 6 commits into from
Nov 25, 2024
Merged

fix: python version warning #3570

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
18f8d49
fix: python version warning
germa89 Nov 22, 2024
f6c19cd
chore: adding changelog file 3570.fixed.md [dependabot-skip]
pyansys-ci-bot Nov 22, 2024
41db24e
feat: using a function to retrieve the python version
germa89 Nov 25, 2024
c08eed6
tests: adding tests
germa89 Nov 25, 2024
526e513
refactor: using multiple context managers in with.
germa89 Nov 25, 2024
7fcc4fe
refactor: removing as.
germa89 Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/3570.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix: python version warning
2 changes: 1 addition & 1 deletion src/ansys/mapdl/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
BUILDING_GALLERY: bool = False
RUNNING_TESTS: bool = False

DEPRECATING_MINIMUM_PYTHON_VERSION: bool = True
DEPRECATING_MINIMUM_PYTHON_VERSION: bool = False
MINIMUM_PYTHON_VERSION: Tuple[int, int] = (3, 10)

# Import related globals
Expand Down
2 changes: 1 addition & 1 deletion src/ansys/mapdl/core/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def run_first_time() -> None:
"release."
)

if sys.version_info[1] <= MINIMUM_PYTHON_VERSION[1]:
if sys.version_info[1] < MINIMUM_PYTHON_VERSION[1]:
warn(
f"Python {py_ver} is not being tested or officially supported. "
"It is recommended you use a newer version of Python. "
Expand Down
Loading