Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace get_ansys_path with get_mapdl_path #3573

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 25, 2024

Description

As the title.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner November 25, 2024 16:54
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 25, 2024 16:54
@germa89 germa89 self-assigned this Nov 25, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement Improve any current implemented feature label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.97%. Comparing base (3635824) to head (31346e1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3573      +/-   ##
==========================================
+ Coverage   86.94%   86.97%   +0.03%     
==========================================
  Files         187      187              
  Lines       14622    14623       +1     
==========================================
+ Hits        12713    12719       +6     
+ Misses       1909     1904       -5     

@germa89 germa89 mentioned this pull request Nov 25, 2024
10 tasks
@germa89
Copy link
Collaborator Author

germa89 commented Nov 25, 2024

I need to merge first #3576

@germa89 germa89 enabled auto-merge (squash) November 26, 2024 10:43
@germa89
Copy link
Collaborator Author

germa89 commented Nov 26, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit aad1006 into main Nov 26, 2024
43 of 50 checks passed
@germa89 germa89 deleted the refactor/replace-get_ansys_path-with-get_mapdl_path branch November 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants