Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improving load_array to reduce format line length #3590

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 28, 2024

Description

As the title.

Issue linked

NA but related to #3583

Checklist

@germa89 germa89 requested a review from a team as a code owner November 28, 2024 11:24
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 28, 2024 11:24
@germa89 germa89 self-assigned this Nov 28, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (4243345) to head (a5a9676).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3590      +/-   ##
==========================================
- Coverage   86.97%   86.97%   -0.01%     
==========================================
  Files         187      187              
  Lines       14623    14623              
==========================================
- Hits        12719    12718       -1     
- Misses       1904     1905       +1     

@germa89
Copy link
Collaborator Author

germa89 commented Nov 29, 2024

https://youtu.be/v2H1s9gj5DA?si=iFqzAfp-k3ekp49s&t=174

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 4a2a4f2 into main Nov 29, 2024
47 of 52 checks passed
@germa89 germa89 deleted the feat/improving-load_array-to-reduce-format-length branch November 29, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants