Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid errors when retrieving invalid routine #3606

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 9, 2024

Description

As the title. Sometimes, MAPDL retrieves back a wrong routine number. We should not raise an exception, and just finish the current routine.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner December 9, 2024 13:18
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team December 9, 2024 13:18
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Dec 9, 2024
@github-actions github-actions bot added the new feature Request or proposal for a new feature label Dec 9, 2024
@germa89 germa89 changed the title feat: avoid errors when retriving invalid routine feat: avoid errors when retrieving invalid routine Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (27c6ec9) to head (7957545).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3606   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files         187      187           
  Lines       14628    14632    +4     
=======================================
+ Hits        12725    12729    +4     
  Misses       1903     1903           

@germa89
Copy link
Collaborator Author

germa89 commented Dec 11, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 3c81f2d into main Dec 13, 2024
52 checks passed
@germa89 germa89 deleted the fix/avoid-error-when-retriving-routine branch December 13, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants