Skip to content

Commit

Permalink
Fix extension manifest (host) permissions
Browse files Browse the repository at this point in the history
Both ways of defining them are equivalent strictly, as per
https://developer.chrome.com/docs/extensions/mv3/match_patterns/, since
the path is always treated as /* (so the three entries were the same and
that's why we could inject to other pages such as /*/profile/*), but
this change makes it clear.

Change-Id: Ic60757ce86411b663efc3e2b6bbb0b29d987a4bd
  • Loading branch information
avm99963 committed Jun 9, 2021
1 parent 56d4d18 commit d75966e
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions templates/manifest.gjson
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#endif
"name": "__MSG_appName__",
"version": "0",
#if defined(CHROMIUM || CHROMIUM_MV3)
#if defined(CHROMIUM || CHROMIUM_MV3)
"version_name": "dirty",
#endif
"description": "__MSG_appDescription__",
Expand Down Expand Up @@ -48,18 +48,14 @@
}
],
"permissions": [
#if defined(CHROMIUM || GECKO)
"https://support.google.com/s/community*",
"https://support.google.com/*/threads*",
"https://support.google.com/*/thread/*",
#if defined(CHROMIUM || GECKO)
"https://support.google.com/*",
#endif
"storage"
],
#if defined(CHROMIUM_MV3)
"host_permissions": [
"https://support.google.com/s/community*",
"https://support.google.com/*/threads*",
"https://support.google.com/*/thread/*"
"https://support.google.com/*"
],
#endif
"web_accessible_resources": [
Expand All @@ -83,7 +79,7 @@
}
#endif
],
#if defined(CHROMIUM || GECKO)
#if defined(CHROMIUM || GECKO)
"browser_action": {},
#endif
#if defined(CHROMIUM_MV3)
Expand Down

0 comments on commit d75966e

Please sign in to comment.