update DRA driver error injection #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A call might have started, but not completed yet. That should not be considered a "successful" call.
…rceptor Previously, blocking and error injection where implemented inside the kubelet plugin code of the driver. This was a bit hacky and not thread-safe (no locking). For upcoming tests we need more flexibility. Now a test can inject its own gRPC interceptor into the kubelet plugin code. A pre-built one supports blocking and error injection, but completely different interceptors are also possible if needed.
pohly
commented
Apr 30, 2024
| // and some other configuration. | ||
| type FileOperations struct { | ||
| type PluginConfig struct { |
There was a problem hiding this comment.
Renaming this was overdue. Should have done it already earlier when adding NumResourceInstances...
bart0sh
force-pushed
the
PR144-e2e_node-DRA-test-plugin-failures
branch
6 times, most recently
from
60321bb to
2068c33
Compare
bart0sh
force-pushed
the
PR144-e2e_node-DRA-test-plugin-failures
branch
4 times, most recently
from
8b82ac1 to
da7720f
Compare
bart0sh
force-pushed
the
PR144-e2e_node-DRA-test-plugin-failures
branch
5 times, most recently
from
28c9c30 to
200bd1c
Compare
bart0sh
force-pushed
the
PR144-e2e_node-DRA-test-plugin-failures
branch
2 times, most recently
from
f1b3ac4 to
ee0340a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I can imaging writing the new E2E node tests.
Note that
[sig-node] DRA [Feature:DynamicResourceAllocation] [NodeAlphaFeature:DynamicResourceAllocation] Resource Kubelet Plugin [Serial] [It] must call NodeUnprepareResources for deleted pod after Kubelet restart [sig-node, Feature:DynamicResourceAllocation, Serial]fails for me, kubelet does not call NodeUnprepareResources again after the restart./assign @bart0sh