Added kubeflow pipelines launcher rock image #158

BON4 · 2024-11-28T14:39:28Z

Description

Add rockcraft.yaml
Add tests
Add tox.ini

This is re-open request for #110.

Logs

Using kfp-operators. Modified kfp-api/config.yaml. Replaced "gcr.io/ml-pipeline/kfp-launcher@sha256:bef55a344574a25c557256d7c66cb19edacfd2008d694e5b6bb5b612d59feae0" with "vyurchenko581/kfp-launcher:2.2.0".

Additionally, the default port for KUBEFLOW_LOCAL_HOST has been changed from 8080 to 8081 due to its unavailability on my local machine, as it is already in use.

Juju status after all tests passed:

Model     Controller          Cloud/Region        Version  SLA          Timestamp
kubeflow  microk8s-localhost  microk8s/localhost  3.5.4    unsupported  16:06:46+02:00

App                      Version                  Status  Scale  Charm                    Channel       Rev  Address         Exposed  Message
argo-controller                                   active      1  argo-controller          latest/edge   607  10.152.183.85   no       
envoy                                             active      1  envoy                    latest/edge   307  10.152.183.222  no       
istio-ingressgateway                              active      1  istio-gateway            latest/edge  1287  10.152.183.95   no       
istio-pilot                                       active      1  istio-pilot              latest/edge  1235  10.152.183.61   no       
kfp-api                                           active      1  kfp-api                                  0  10.152.183.219  no       
kfp-db                   8.0.37-0ubuntu0.22.04.3  active      1  mysql-k8s                8.0/stable    180  10.152.183.202  no       
kfp-metadata-writer                               active      1  kfp-metadata-writer                      0  10.152.183.230  no       
kfp-persistence                                   active      1  kfp-persistence                          0  10.152.183.201  no       
kfp-profile-controller                            active      1  kfp-profile-controller                   0  10.152.183.185  no       
kfp-schedwf                                       active      1  kfp-schedwf                              0  10.152.183.173  no       
kfp-ui                                            active      1  kfp-ui                                   0  10.152.183.153  no       
kfp-viewer                                        active      1  kfp-viewer                               0  10.152.183.47   no       
kfp-viz                                           active      1  kfp-viz                                  0  10.152.183.189  no       
kubeflow-profiles                                 active      1  kubeflow-profiles        latest/edge   456  10.152.183.200  no       
kubeflow-roles                                    active      1  kubeflow-roles           latest/edge   264  10.152.183.220  no       
metacontroller-operator                           active      1  metacontroller-operator  latest/edge   349  10.152.183.250  no       
minio                    res:oci-image@220b31a    active      1  minio                    latest/edge   376  10.152.183.21   no       
mlmd                                              active      1  mlmd                     latest/edge   243  10.152.183.121  no       

Unit                        Workload  Agent  Address       Ports          Message
argo-controller/0*          active    idle   10.1.142.144                 
envoy/0*                    active    idle   10.1.142.156                 
istio-ingressgateway/0*     active    idle   10.1.142.179                 
istio-pilot/0*              active    idle   10.1.142.167                 
kfp-api/0*                  active    idle   10.1.142.152                 
kfp-db/0*                   active    idle   10.1.142.145                 Primary
kfp-metadata-writer/0*      active    idle   10.1.142.165                 
kfp-persistence/0*          active    idle   10.1.142.177                 
kfp-profile-controller/0*   active    idle   10.1.142.146                 
kfp-schedwf/0*              active    idle   10.1.142.185                 
kfp-ui/0*                   active    idle   10.1.142.168                 
kfp-viewer/0*               active    idle   10.1.142.181                 
kfp-viz/0*                  active    idle   10.1.142.138                 
kubeflow-profiles/0*        active    idle   10.1.142.143                 
kubeflow-roles/0*           active    idle   10.1.142.161                 
metacontroller-operator/0*  active    idle   10.1.142.188                 
minio/0*                    active    idle   10.1.142.175  9000-9001/TCP  
mlmd/0*                     active    idle   10.1.142.131

Logs of passed integration tests tox -vve bundle-integration-v2 -- --model kubeflow --bundle=./tests/integration/bundles/kfp_latest_edge.yaml.j2 --keep-models:

ROOT: 144 D setup logging to DEBUG on pid 778425 [tox/report.py:222]
bundle-integration-v2: 221 D clear env temp folder /home/yurchenko/kfp-operators/.tox/bundle-integration-v2/tmp [tox/tox_env/api.py:313]
bundle-integration-v2: 228 I find interpreter for spec PythonSpec(path=/home/yurchenko/kfp-operators/env/bin/python) [virtualenv/discovery/builtin.py:74]
bundle-integration-v2: 228 D filesystem is case-sensitive [virtualenv/info.py:26]
bundle-integration-v2: 229 D got python info of %s from (PosixPath('/usr/bin/python3.12'), PosixPath('/home/yurchenko/.local/share/virtualenv/py_info/1/f0d7a494a3f776233427cb85a7e198c7cf4913b50a203c6febc678cc4f5bf265.json')) [virtualenv/app_data/via_disk_folder.py:133]
bundle-integration-v2: 229 I proposed PythonInfo(spec=CPython3.12.3.final.0-64, system=/usr/bin/python3.12, exe=/home/yurchenko/kfp-operators/env/bin/python, platform=linux, version='3.12.3 (main, Nov  6 2024, 18:32:19) [GCC 13.2.0]', encoding_fs_io=utf-8-utf-8) [virtualenv/discovery/builtin.py:81]
bundle-integration-v2: 229 D accepted PythonInfo(spec=CPython3.12.3.final.0-64, system=/usr/bin/python3.12, exe=/home/yurchenko/kfp-operators/env/bin/python, platform=linux, version='3.12.3 (main, Nov  6 2024, 18:32:19) [GCC 13.2.0]', encoding_fs_io=utf-8-utf-8) [virtualenv/discovery/builtin.py:83]
bundle-integration-v2: 284 W commands[0]> pytest -vv --tb=native -s --model kubeflow --bundle=./tests/integration/bundles/kfp_latest_edge.yaml.j2 --keep-models /home/yurchenko/kfp-operators/tests/integration/test_kfp_functional_v2.py [tox/tox_env/api.py:427]
/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/paramiko/pkey.py:100: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
  "cipher": algorithms.TripleDES,
/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/paramiko/transport.py:259: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
  "class": algorithms.TripleDES,
============================================================================================= test session starts ==============================================================================================
platform linux -- Python 3.12.3, pytest-8.3.2, pluggy-1.5.0 -- /home/yurchenko/kfp-operators/.tox/bundle-integration-v2/bin/python
cachedir: .tox/bundle-integration-v2/.pytest_cache
rootdir: /home/yurchenko/kfp-operators
configfile: pyproject.toml
plugins: operator-0.35.0, asyncio-0.21.2, anyio-4.4.0
asyncio: mode=Mode.STRICT
collected 6 items                                                                                                                                                                                              

tests/integration/test_kfp_functional_v2.py::test_build_and_deploy PASSED
tests/integration/test_kfp_functional_v2.py::test_upload_pipeline Forwarding from 127.0.0.1:8081 -> 3000
Forwarding from [::1]:8081 -> 3000
Handling connection for 8081
Handling connection for 8081
PASSED
tests/integration/test_kfp_functional_v2.py::test_create_and_monitor_run Handling connection for 8081
Handling connection for 8081
Experiment details: http://localhost:8081/#/experiments/details/7e354753-7948-4b16-8acf-253aa0ac1cc5
Handling connection for 8081
Experiment details: http://localhost:8081/#/experiments/details/7e354753-7948-4b16-8acf-253aa0ac1cc5
Handling connection for 8081
Run details: http://localhost:8081/#/runs/details/9e20574f-9b5a-4627-acae-653a8e9db392
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
PASSEDHandling connection for 8081

tests/integration/test_kfp_functional_v2.py::test_create_and_monitor_recurring_run Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Experiment details: http://localhost:8081/#/experiments/details/32d694e6-9097-468e-b745-da65c7a37b0b
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
PASSEDHandling connection for 8081
Handling connection for 8081
Handling connection for 8081

tests/integration/test_kfp_functional_v2.py::test_apply_sample_viewer PASSED
tests/integration/test_kfp_functional_v2.py::test_viz_server_healthcheck PASSED

=============================================================================================== warnings summary ===============================================================================================
tests/integration/test_kfp_functional_v2.py::test_build_and_deploy
  /home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/sh.py:1980: DeprecationWarning: This process (pid=778431) is multi-threaded, use of fork() may lead to deadlocks in the child.
    self.pid = os.fork()

tests/integration/test_kfp_functional_v2.py::test_upload_pipeline
  /home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/kfp/client/client.py:159: FutureWarning: This client only works with Kubeflow Pipeline v2.0.0-beta.2 and later versions.
    warnings.warn(

tests/integration/test_kfp_functional_v2.py: 29 warnings
  /home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/kfp_server_api/rest.py:47: DeprecationWarning: HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTPResponse.headers.get(name, default).
    return self.urllib3_response.getheader(name, default)

tests/integration/test_kfp_functional_v2.py::test_viz_server_healthcheck
  /home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/_pytest/stash.py:108: RuntimeWarning: coroutine 'Connection.reconnect' was never awaited
    del self._storage[key]
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================================== 6 passed, 32 warnings in 425.60s (0:07:05) ==================================================================================
Task exception was never retrieved
future: <Task finished name='Task-32' coro=<Model._watch.<locals>._all_watcher() done, defined at /home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/juju/model.py:1194> exception=TypeError('Passing coroutines is forbidden, use tasks explicitly.')>
Traceback (most recent call last):
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/websockets/legacy/protocol.py", line 1301, in close_connection
    await self.transfer_data_task
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/websockets/legacy/protocol.py", line 963, in transfer_data
    message = await self.read_message()
              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/websockets/legacy/protocol.py", line 1033, in read_message
    frame = await self.read_data_frame(max_size=self.max_size)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/websockets/legacy/protocol.py", line 1108, in read_data_frame
    frame = await self.read_frame(max_size)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/websockets/legacy/protocol.py", line 1165, in read_frame
    frame = await Frame.read(
            ^^^^^^^^^^^^^^^^^
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/websockets/legacy/framing.py", line 68, in read
    data = await reader(2)
           ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/asyncio/streams.py", line 752, in readexactly
    await self._wait_for_data('readexactly')
  File "/usr/lib/python3.12/asyncio/streams.py", line 545, in _wait_for_data
    await self._waiter
asyncio.exceptions.CancelledError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/juju/client/connection.py", line 649, in rpc
    await self._ws.send(outgoing)
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/websockets/legacy/protocol.py", line 635, in send
    await self.ensure_open()
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/websockets/legacy/protocol.py", line 939, in ensure_open
    raise self.connection_closed_exc()
websockets.exceptions.ConnectionClosedError: sent 1011 (internal error) keepalive ping timeout; no close frame received

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/juju/model.py", line 1206, in _all_watcher
    results = await utils.run_with_interrupt(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yurchenko/kfp-operators/.tox/bundle-integration-v2/lib/python3.12/site-packages/juju/utils.py", line 191, in run_with_interrupt
    return task.result()  # may raise exception
           ^^^^^^^^^^^^^
TypeError: Passing coroutines is forbidden, use tasks explicitly.
bundle-integration-v2: 427498 I exit 0 (427.21 seconds) /home/yurchenko/kfp-operators> pytest -vv --tb=native -s --model kubeflow --bundle=./tests/integration/bundles/kfp_latest_edge.yaml.j2 --keep-models /home/yurchenko/kfp-operators/tests/integration/test_kfp_functional_v2.py pid=778431 [tox/execute/api.py:286]
  bundle-integration-v2: OK (427.28=setup[0.07]+cmd[427.21] seconds)
  congratulations :) (427.36 seconds)

DnPlas

Thanks @BON4 ! I have reviewed this PR by:

Building the rock -> Success
Running a container with the image and looking for the files and binaries -> Success

_daemon_@e73d0fc692a2:/$ ls -la bin/launcher-v2
-rwxr-xr-x 1 _daemon_ users 68083814 Nov 29 15:56 bin/launcher-v2
_daemon_@e73d0fc692a2:/$ ls /third_party/NOTICES/
cloud.google.com  github.com  go.opencensus.io	gocloud.dev  golang.org  google.golang.org  gopkg.in  k8s.io  sigs.k8s.io
_daemon_@e73d0fc692a2:/$ ls /third_party/licenses.csv
/third_party/licenses.csv

There is just one sanity check that is not passing because it's looking for a file that does not exist. After correcting that, I can approve this PR.

launcher/tests/test_rock.py

launcher/rockcraft.yaml

Change version to correct one Co-authored-by: Daniela Plascencia <daniela.plascencia@canonical.com>

BON4 added 3 commits November 28, 2024 15:27

kfp-launcher rock and test

91335df

kfp-launcher rock and test

fcd0dd9

kfp-launcher rock and test

f3f41ae

BON4 marked this pull request as ready for review November 28, 2024 15:29

BON4 requested a review from a team as a code owner November 28, 2024 15:29

BON4 added 2 commits November 29, 2024 10:58

kfp-launcher rock and test

e46391a

kfp-launcher rock and test

c7283c3

DnPlas requested changes Nov 29, 2024

View reviewed changes

launcher/tests/test_rock.py Outdated Show resolved Hide resolved

BON4 added 3 commits November 30, 2024 08:00

kfp-launcher rock and test

6508de3

kfp-launcher rock and test

ac8c942

kfp-launcher rock and test

338a4d5

BON4 requested a review from DnPlas December 2, 2024 13:52

DnPlas requested changes Dec 2, 2024

View reviewed changes

launcher/rockcraft.yaml Outdated Show resolved Hide resolved

Update launcher/rockcraft.yaml

8a29cf5

Change version to correct one Co-authored-by: Daniela Plascencia <daniela.plascencia@canonical.com>

BON4 requested a review from DnPlas December 3, 2024 08:27

DnPlas approved these changes Dec 3, 2024

View reviewed changes

DnPlas merged commit e5ad32c into canonical:main Dec 3, 2024
7 checks passed

DnPlas mentioned this pull request Dec 3, 2024

Review kfp-launcher rock #157

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added kubeflow pipelines launcher rock image #158

Added kubeflow pipelines launcher rock image #158

BON4 commented Nov 28, 2024

DnPlas left a comment

Added kubeflow pipelines launcher rock image #158

Added kubeflow pipelines launcher rock image #158

Conversation

BON4 commented Nov 28, 2024

Description

Logs

DnPlas left a comment

Choose a reason for hiding this comment