Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: patch for visualization server #35

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

i-chvets
Copy link
Contributor

@i-chvets i-chvets commented Sep 21, 2023

Description

Initial PR for patching of existing ROCK. Follows best practices and CVE managent spec.

Summary of changes:

  • Initial patch for visualization server.
  • Added requirements.in file with relaxed requirements.
  • Added tensorflow installation inside rockcraft.yaml with fixed Tensorflow version.
  • Updated to Python 3.8

NOTE: ROCK might not be functional due to errors in dependencies:

023-09-21 18:56:59.019 :: ERROR: google-auth 2.23.0 has requirement urllib3<2.0, but you'll have urllib3 2.0.5 which is incompatible.                    
2023-09-21 18:56:59.020 :: ERROR: tensorflow-metadata 1.14.0 has requirement absl-py<2.0.0,>=0.9, but you'll have absl-py 2.0.0 which is incompatible.    
2023-09-21 18:56:59.020 :: ERROR: tensorflow-metadata 1.14.0 has requirement protobuf<4.21,>=3.20.3, but you'll have protobuf 3.19.6 which is incompatible.                                                                                                                                                          
2023-09-21 18:56:59.020 :: ERROR: tensorflow-serving-api 2.13.0 has requirement protobuf!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.20.3, but you'll have protobuf 3.19.6 which is incompatible.                                                                                             
2023-09-21 18:56:59.020 :: ERROR: tensorflow-serving-api 2.13.0 has requirement tensorflow<3,>=2.13.0, but you'll have tensorflow 2.11.1 which is incompatible.                                                                                                                                                      
2023-09-21 18:56:59.020 :: ERROR: grpcio-status 1.58.0 has requirement protobuf>=4.21.6, but you'll have protobuf 3.19.6 which is incompatible.           
2023-09-21 18:56:59.020 :: ERROR: apache-beam 2.50.0 has requirement protobuf<4.24.0,>=3.20.3, but you'll have protobuf 3.19.6 which is incompatible.     
2023-09-21 18:56:59.020 :: ERROR: tfx-bsl 1.14.0 has requirement absl-py<2.0.0,>=0.9, but you'll have absl-py 2.0.0 which is incompatible.                
2023-09-21 18:56:59.020 :: ERROR: tfx-bsl 1.14.0 has requirement protobuf<5,>=3.20.3, but you'll have protobuf 3.19.6 which is incompatible.              
2023-09-21 18:56:59.020 :: ERROR: tfx-bsl 1.14.0 has requirement tensorflow<3,>=2.13, but you'll have tensorflow 2.11.1 which is incompatible.            
2023-09-21 18:56:59.020 :: ERROR: referencing 0.30.2 has requirement attrs>=22.2.0, but you'll have attrs 21.4.0 which is incompatible.                   
2023-09-21 18:56:59.020 :: ERROR: jsonschema 4.19.1 has requirement attrs>=22.2.0, but you'll have attrs 21.4.0 which is incompatible.                    
2023-09-21 18:56:59.021 :: ERROR: tensorflow-model-analysis 0.45.0 has requirement absl-py<2.0.0,>=0.9, but you'll have absl-py 2.0.0 which is incompatible.                                                                                                                                                         
2023-09-21 18:56:59.021 :: ERROR: tensorflow-model-analysis 0.45.0 has requirement protobuf<5,>=3.20.3, but you'll have protobuf 3.19.6 which is incompatible.                                                                                                                                                       
2023-09-21 18:56:59.021 :: ERROR: tensorflow-model-analysis 0.45.0 has requirement tensorflow<3,>=2.13, but you'll have tensorflow 2.11.1 which is incompatible.                                                                                                                                                     
2023-09-21 18:56:59.021 :: ERROR: tensorflow-data-validation 1.14.0 has requirement absl-py<2.0.0,>=0.9, but you'll have absl-py 2.0.0 which is incompatible.                                                                                                                                                        
2023-09-21 18:56:59.021 :: ERROR: tensorflow-data-validation 1.14.0 has requirement protobuf<5,>=3.20.3, but you'll have protobuf 3.19.6 which is incompatible.                                                                                                                                                      
2023-09-21 18:56:59.021 :: ERROR: tensorflow-data-validation 1.14.0 has requirement tensorflow<3,>=2.13, but you'll have tensorflow 2.11.1 which is incompatible.                                                                                                                                                    

Summary of changes:
- Initial patch for visualization server.
@i-chvets i-chvets requested a review from a team as a code owner September 21, 2023 21:09
@@ -22,20 +22,36 @@ package-repositories:
priority: always

parts:
patch:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, you can use the dump plugin: https://snapcraft.io/docs/dump-plugin

- python3.6-venv
python-requirements:
- requirements.txt
- pip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need pip at the end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants