Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update persistenceagent to 2.2.0 #89

Merged
merged 6 commits into from
May 29, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented May 28, 2024

closes: #84

I have compared this file https://github.com/kubeflow/pipelines/blob/2.0.5/backend/Dockerfile.persistenceagent for tags 2.0.5 and 2.2.0. Changes:

  • Go bump
  • new env variables

Other changes:

  • rewritten the rockcraft.yaml based on up to date process
  • added tests for sanity

For experiment I tried to run the integration test for the rock but the bundle test is failing to build charms.

@misohu misohu requested a review from a team as a code owner May 28, 2024 11:42
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, other than that lgtm!

persistenceagent/rockcraft.yaml Outdated Show resolved Hide resolved
persistenceagent/rockcraft.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misohu ! I have packed the rock and tested the binary was there and it works!

@misohu misohu merged commit 8af6d3c into main May 29, 2024
7 checks passed
@misohu misohu deleted the KF-5698-update-persistenceagent-v2-2-0 branch May 29, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update persistenceagent ROCK
2 participants