feat: add "end" job to workflows expected to fail

.github/workflows/build_and_test_eicar_rock.yaml

@@ -16,11 +16,19 @@ jobs:
   test:
     uses: canonical/oci-factory/.github/workflows/Test-Rock.yaml@main
     needs: [build]
-    continue-on-error: true # we expect malware scan to fail
     with:
       oci-archive-name: "eicar-rock"
       test-black-box: true
       test-efficiency: true
       test-malware: true
       test-oci-compliance: true
       test-vulnerabilities: true
+
+  end:
+    # we expect malware scan to fail, so we add a final job so PR checks pass.
+    if: ${{ !cancelled() }}
+    needs: [test]
+    runs-on: ubuntu-22.04
+    steps:
+      - run: |
+          echo Workflow complete!

.github/workflows/test_external_rock.yaml

@@ -31,11 +31,19 @@ jobs:
   test:
     uses: canonical/oci-factory/.github/workflows/Test-Rock.yaml@main
     needs: [setup]
-    continue-on-error: true # we expect vulnerabilities scan to fail
     with:
       oci-archive-name: test_image
       test-black-box: false # will always fail since bkimminich/juice-shop is not a rock. 
       test-efficiency: true
       test-malware: true
       test-oci-compliance: true
       test-vulnerabilities: true
+
+  end:
+    # we expect vulnerabilities scan to fail, so we add a final job so PR checks pass.
+    if: ${{ !cancelled() }}
+    needs: [test]
+    runs-on: ubuntu-22.04
+    steps:
+      - run: |
+          echo Workflow complete!