Examples and brief docs for oci-factory's reusable workflows #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdcordeiro
reviewed
Dec 3, 2024
cjdcordeiro
requested changes
Dec 5, 2024
There was a problem hiding this comment.
LGTM. Can we rename the GH workflows to have some form of identifier? Since this is a sort of catch-all repo, it's safer to name things as explicitly as possible, especially when the files may be mixed with others from different contexts.
So, what about adding a prefix like "oci_factory"? And the same for the workflow names
clay-lake
commented
Dec 6, 2024
clay-lake
commented
Dec 6, 2024
clay-lake
force-pushed
the
rework_oci-factory_workflow_docs
branch
from
7a78c6d to
2f78f41
Compare
|
Can you squash and sign? The branch protection doesn't allow me to merge without signing the commits |
clay-lake
force-pushed
the
rework_oci-factory_workflow_docs
branch
from
e6a338f to
d2f6f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features included in this PR: