Word count split feature added to new view #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujitv19196
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Still needs a merge (git pull origin staging) and then resolve the merge conflicts. I think there are actually no merge conflicts.- Also I had to remove some code from index.js that was not being used for any functionality. Be careful that when you copy-paste you understand the functionality you are copy-pasting over.
| @@ -0,0 +1,104 @@ | |||
| import React, {useState} from 'react'; | |||
There was a problem hiding this comment.
Can we move this file into the EditINote folder
meg-ghana
force-pushed
the
staging-word-count-split
branch
from
3b95ecb to
99c222e
Compare
sujitv19196
requested changes
Sep 25, 2023
Comment on lines
12
to
13
| import Instruction from '../EditEPubStructure/Instruction'; | ||
| import EPubItemView from '../EditEPubStructure/EPubItemView'; |
There was a problem hiding this comment.
unused code. I thought i deleted this in my commit. Pleas delete
Comment on lines
24
to
45
| const [instExp, setInstExp] = useState(true); | ||
|
|
||
| const toggleInstExp = (e, newExpanded) => setInstExp(newExpanded); | ||
|
|
||
| useEffect(() => { | ||
| // show the user onboard guide if possible | ||
| setTimeout(() => { | ||
| const guide = generateEPubGuide(); | ||
| guide.start(); | ||
| }, 1000); | ||
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| if (Boolean(ePubItem) && instExp) { | ||
| setInstExp(false); | ||
| } | ||
| }, [ePubItem]); | ||
| const itemViewElem = altEl(EPubItemView, Boolean(ePubItem), { | ||
| item: ePubItem, setEPubItem | ||
| }); | ||
| const btnStyles = useButtonStyles(); | ||
| const btnClasses = cx(btnStyles.tealLink, 'justify-content-start'); |
There was a problem hiding this comment.
I think most of this is unused functionality. We are no longer displaying the instruction and guide to the user. Delete all that does not pertain to the split menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.