Upgrade Jest setup to latest v29 from v26 #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh183
commented
Jun 8, 2024
| @@ -15,7 +15,7 @@ const hasJsxRuntime = (() => { | |||
| } | |||
| })(); | |||
|
|
|||
| module.exports = babelJest.createTransformer({ | |||
| module.exports = babelJest.default.createTransformer({ | |||
There was a problem hiding this comment.
linariaplug/craco-linaria3#4 - worked
harsh183
commented
Jun 8, 2024
| @@ -5,7 +5,9 @@ | |||
|
|
|||
| module.exports = { | |||
| process() { | |||
| return 'module.exports = {};'; | |||
| return { | |||
There was a problem hiding this comment.
the shape of the return slightly changed, I followed this guide: https://web.archive.org/web/20230330085721/https://jestjs.io/docs/28.x/upgrading-to-jest28#transformer
harsh183
changed the title
harsh183
force-pushed
the
hd/upgrade-babel-jest-deps
branch
from
21aa513 to
88172f4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't use the latest Jest in the first PR since we were on Node 16, but now that we're on 18, I upgraded to recent Jest. There were some minor breaking changes with the CRA ejected config but I think I have it sorted.
Also upgraded accompanying babel config and moved more things to the dev dependencies side.
https://jestjs.io/blog/2021/05/25/jest-27
https://web.archive.org/web/20230330085721/https://jestjs.io/docs/28.x/upgrading-to-jest28#transformer