Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

838 caption guidelines #838

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

838 caption guidelines #838

wants to merge 2 commits into from

Conversation

Jeybird248
Copy link
Contributor

  • added functionality to view warnings for subtitle caption length (not audio descriptions)
  • subtitle captions are given warning for:
    • being too short in time ( < 1.5 seconds)
    • being too long in time ( > 6 seconds)
    • being too long in length ( > 2 lines, where each line has max 42 characters)
  • warnings are shown through a red triangle ( rgb(204, 0, 0) for contrast )
  • fixed bug where editing text resets violations array
  • reasoning for warning can be seen when on focus of caption, accessible by selecting using tab button
2024-12-12 02_09_58-

@Jeybird248 Jeybird248 requested a review from angrave December 12, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant