feat: Lesson_05 DataProvider implementation #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydmays
requested changes
Mar 11, 2024
| public Map<String, Class> getColumnTypeByName() { | ||
| return Map.of( | ||
| "column1", Long.class, | ||
| "column2", BigDecimal.class, |
There was a problem hiding this comment.
In the instructions, you were directed to use the "closest possible data type." There is a different data types that would be more efficient to store the data in column2 based on its size.
Switched to Short datatype for efficiency
|
Why did you close this PR? This looks like a valid submission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AaronSantiagoProvider with customized data type mappings