feat: Implement data loading for books in CsvDataLoader #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functionality to CsvDataLoader to load data for books from the provided. Implemented book details such as title, ISBN, authors, and number of pages from MediaItemModel objects and create Book instances accordingly. This allows CsvDataLoader to handle loading data for books and improves the flexibility of the application.
and refactored the cvs data loader
…csv data loader to pass tests.
anthonydmays
requested changes
Mar 28, 2024
| private static final String CSV_FILE_PATH = "src/main/resources/csv/data.csv"; | ||
|
|
||
| @Override | ||
| public LibraryDataModel loadData() throws IOException { |
There was a problem hiding this comment.
Looks like you're on the right track, just need to finish.
| } | ||
|
|
||
| // Method to create a MediaItemModel object from CSV data | ||
| private MediaItemModel createMediaItemFromCsvData(String[] data) { |
There was a problem hiding this comment.
Great idea pulling this method. Good use of the single responsibility principle.
…with recognizing my bean annotation
…hanged previous method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to CsvDataLoader to load data for books from the provided. Implemented book details such as title, ISBN, authors, and number of pages from MediaItemModel objects and create Book instances accordingly. This allows CsvDataLoader to handle loading data for books and improves the flexibility of the application.