Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JadasBankAtm #326

Closed
wants to merge 11 commits into from
Closed

JadasBankAtm #326

wants to merge 11 commits into from

Conversation

Nelshulla
Copy link
Contributor

No description provided.

Nelshulla and others added 6 commits March 29, 2024 05:06
@Nelshulla
feat: implemented librarian, Magazine,Newspaper,Exceptions
6c7cc55
@Nelshulla
feat: Implement CSV data loader for library
0954474 
- Added LibraryCsvDataLoaderImpl class
- Implemented methods to load data from CSV files
- Used OpenCSV library for parsing CSV files
@Nelshulla
Revert "feat: implemented librarian, Magazine,Newspaper,Exceptions"
74690a3 
This reverts commit 56e58f0.
@Nelshulla
Revert "feat: implemented librarian, Magazine,Newspaper,Exceptions"
55a8181 
This reverts commit 56e58f0.
@Nelshulla
feat: Had to do spotlessApply
65118ed
@Nelshulla
feat: add checking account to the bank, updated depositFunds and With…
30f64b7 
…drawFunds w/MoneyOrder, added BusinessCustomer, added FinancialInstrument interface,added Customer
@Nelshulla Nelshulla closed this Mar 29, 2024
@Nelshulla Nelshulla reopened this Mar 29, 2024
@Nelshulla
Copy link
Contributor Author

Hey, I need some help, my deposit funds and withdraw funds tests are failing. The error says the account is not found. I don't understand what this means

@anthonydmays
Copy link
Contributor

Hey, I need some help, my deposit funds and withdraw funds tests are failing. The error says the account is not found. I don't understand what this means

Try to troubleshoot by setting a breakpoint in the withdrawalFunds method and debug the test to step through the code line by line.

anthonydmays
anthonydmays requested changes Apr 2, 2024
View reviewed changes
lesson_13/bank/bank_app/src/main/java/com/codedifferently/lesson13/bank/BankAtm.java
*/
public void depositFunds(String accountNumber, double amount) {
public void depositFunds(String accountNumber, MoneyOrder moneyOrder) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that Check and a MoneyOrder both implement the FinancialInstrument interface and can be provided to the other depositFunds method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydmays anthonydmays anthonydmays requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nelshulla @anthonydmays