Feat: Added and Updated Accounts #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydmays
requested changes
Apr 2, 2024
| * | ||
| * @author vscode | ||
| */ | ||
| public class BankAccountBase { |
There was a problem hiding this comment.
This base class should implement the BankAccount interface.
| import com.codedifferently.lesson13.bank.exceptions.AccountNotFoundException; | ||
| import com.codedifferently.lesson13.bank.BankAccount; | ||
|
|
||
| public class BusinessCheckingAccount extends Customer { |
There was a problem hiding this comment.
I would expect this to extend BankAccountBase or CheckingAccount. A banking account is not a customer.
|
|
||
| /** Represents a checking account. */ | ||
| public class BankAccountBase implements BankAccount { |
There was a problem hiding this comment.
Not sure what happened here.
| @@ -23,8 +23,8 @@ void setUp() { | |||
| classUnderTest = new BankAtm(); | |||
| customer1 = new Customer(UUID.randomUUID(), "John Doe"); | |||
| customer2 = new Customer(UUID.randomUUID(), "Jane Smith"); | |||
| account1 = new CheckingAccount("123456789", Set.of(customer1), 100.0); | |||
| account2 = new CheckingAccount("987654321", Set.of(customer1, customer2), 200.0); | |||
| account1 = new BankAccount("123456789", Set.of(customer1), 100.0); | |||
There was a problem hiding this comment.
You can't create an instance of an interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.