Skip to content

Commit

Permalink
Enable cloud status in status bar to be read by NVDA
Browse files Browse the repository at this point in the history
Problem:
Using either Jaws or NVDA the cloud status is not read when reading the status line.
Using the Inspect tool, in its tree view it can be seen that there is no child of the status line which has an accessibility name which is the cloud status.
The status line has a WindowAccessible set, so that the accessibility name of the status line can be set to "status_line". WindowAccessible is dealing with the accessibility objects of the status bar's children, and not doing a very good job. (It's not written to be able to do this.)

Fix for NVDA only:
Don't set a WindowAccessible for the status line, and let Windows provide the accessible objects for the status line, and for all the children for which an accessibility object is not set.
This means that the status line no longer has the accessibility name of "status_line". I'm not sure when this was introduced and why. But neither the current Jaws or NVDA scripts make use of the name, so I don't see any problem.

Note on Jaws:
This fix does not fix the issue for the Jaws screen reader. It looks like it is not using the accessibility objects of the status line for its information about the text on the status line.
  • Loading branch information
DavidBailes authored and crsib committed Apr 8, 2024
1 parent 5cb0575 commit 32854f7
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/ProjectWindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -890,11 +890,6 @@ wxStatusBar* ProjectWindow::CreateProjectStatusBar()
// be an event handler to send them to the appropriate field.
statusBar = CreateStatusBar(
1 + ProjectStatusFieldsRegistry::Count(pProject.get()));
#if wxUSE_ACCESSIBILITY
// so that name can be set on a standard control
statusBar->SetAccessible(safenew WindowAccessible(statusBar));
#endif
statusBar->SetName(wxT("status_line")); // not localized

statusBar->Bind(
wxEVT_SIZE,
Expand Down

0 comments on commit 32854f7

Please sign in to comment.