Fixes the Release builds on MSVC

It seems, there is a bug in the compiler or linker, that optimizes out ItemProperties destructor from the binary, along with the VTable
crsib · Mar 27, 2024 · 409d239 · 409d239
1 parent 2315371
commit 409d239
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/libraries/lib-menus/MenuRegistry.cpp b/libraries/lib-menus/MenuRegistry.cpp
@@ -165,8 +165,6 @@ auto MenuItems::GetOrdering() const -> Ordering {
 }
 auto MenuItems::GetProperties() const -> Properties { return Inline; }
 
-ItemProperties::~ItemProperties() {}
-
 CommandHandlerFinder FinderScope::sFinder =
    [](AudacityProject &project) -> CommandHandlerObject & {
       // If this default finder function is reached, then FinderScope should

diff --git a/libraries/lib-menus/MenuRegistry.h b/libraries/lib-menus/MenuRegistry.h
@@ -111,7 +111,7 @@ namespace MenuRegistry {
          Whole,
          Extension,
       };
-      virtual ~ItemProperties();
+      virtual ~ItemProperties() = default;
       virtual Properties GetProperties() const = 0;
    };