Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #114 #139

Merged
merged 8 commits into from
Mar 12, 2024
Merged

PR for #114 #139

merged 8 commits into from
Mar 12, 2024

Conversation

ryliewalsh
Copy link
Collaborator

Closes #114

Discussion

Updated overall UI for a cleaner look. Implemented new cube button that allows user to upload a different .cube file (not fully tested because we don't have different cube file yet). Implemented an exit button that clears all output and displays instructions on restarting the program.

Removed the original loading widget idea as the response is quicker now will discuss in next meeting.

Testing

  • Run ./build.sh
  • Open GoVizzy.ipynb
  • Run the cells
  • Verify exit works on display menu
  • Verify cube file loads and menu changes
  • Verify exit works on display page
  • Verify when new cube button is pressed display menu is returned

@ryliewalsh ryliewalsh linked an issue Mar 9, 2024 that may be closed by this pull request
3 tasks
@dignojrteogalbo dignojrteogalbo self-requested a review March 10, 2024 00:58
Copy link
Collaborator

@dignojrteogalbo dignojrteogalbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what "Verify exit works on display page" meant but I was able to click the red [X] button to see the message to restart the kernel and re-run the cells. It works on my end.

@ryliewalsh ryliewalsh merged commit 681da62 into main Mar 12, 2024
1 check passed
@ryliewalsh ryliewalsh deleted the UI_try branch March 12, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorient and update UI
3 participants