Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atom color picker options #169

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Atom color picker options #169

merged 6 commits into from
Apr 8, 2024

Conversation

dignojrteogalbo
Copy link
Collaborator

Fixes #161

Discussion

Builds upon changes made by PR #168 to incorporate color picker options.

Testing

  • Run ./build.sh
  • Run GoVizzy.ipynb
  • Switch to "Mesh Options"
  • Verify the toggle visibility still works.
  • Verify the color picker works.
    image

@dignojrteogalbo dignojrteogalbo self-assigned this Apr 8, 2024
matthew-oberg
matthew-oberg requested changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@matthew-oberg matthew-oberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color picker in the mesh page works perfectly, but the drop down menu has a color option that isn't used, remove that.

matthew-oberg
matthew-oberg approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@matthew-oberg matthew-oberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dignojrteogalbo dignojrteogalbo merged commit 915f634 into main Apr 8, 2024
1 check passed
@dignojrteogalbo dignojrteogalbo deleted the color-picker-atoms branch April 8, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryliewalsh ryliewalsh ryliewalsh approved these changes

@matthew-oberg matthew-oberg matthew-oberg approved these changes

@BraydenThompson BraydenThompson Awaiting requested review from BraydenThompson

Assignees

@dignojrteogalbo dignojrteogalbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color picker widget to change colors of atoms
3 participants
@dignojrteogalbo @matthew-oberg @ryliewalsh