Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set slider max to match cube file size #192

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Set slider max to match cube file size #192

merged 1 commit into from
Apr 22, 2024

Conversation

BraydenThompson
Copy link
Collaborator

Closes #191

Discussion

Set slider values to max of each cube file dimension. Note: Aspect ratio within the ipyvolume still forced into a cube, this would need more complicated controls maintain the correct aspect ratio and be able to control which section is shown.

Testing

  • Run build.sh and make sure new dependencies install in .venv
  • Open up the notebook (make sure using the .venv Python kernel)
  • Execute the first cell, and Import a non-rhopol.cube cube file, making sure that the sliders can go to the max of each dimension (-1 for indexing). fukui_negative_defect.cube was used as an example, and has dimensions of 120, 135, 320.
  • Ensure that the 3d slice planes can go all the way to the edge of the graph.
    image

Copy link
Collaborator

@matthew-oberg matthew-oberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@BraydenThompson BraydenThompson merged commit 12d3e34 into main Apr 22, 2024
1 check passed
@BraydenThompson BraydenThompson deleted the task191 branch April 22, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update slider/plot dimensions to match cube file dimensions
4 participants