Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

182 polish project #196

Merged
merged 20 commits into from
Apr 25, 2024
Merged

182 polish project #196

merged 20 commits into from
Apr 25, 2024

Conversation

ryliewalsh
Copy link
Collaborator

Removed file copy
Fixed UI display of new cube

@ryliewalsh ryliewalsh self-assigned this Apr 23, 2024
Copy link
Collaborator

@dignojrteogalbo dignojrteogalbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the selected_view_options output has a height that changes. With rhopol_C4H9NO.cube the button still overlaps. What if we put the "New Cube" button right below the view selector and close? That way the rest of the selected_view_options gets to take up as much space as it needs.
image

Copy link
Collaborator

@dignojrteogalbo dignojrteogalbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't overlap anymore

Copy link
Collaborator

@matthew-oberg matthew-oberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this!

@ryliewalsh ryliewalsh merged commit 97f5593 into main Apr 25, 2024
1 check passed
@ryliewalsh ryliewalsh deleted the 182-polish-project branch April 25, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants