-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meteor 3 #405
Meteor 3 #405
Conversation
api.mainModule('redis-oplog.js', 'server'); | ||
api.mainModule('redis-oplog.client.js', 'client'); | ||
Package.onUse(function (api) { | ||
api.versionsFrom(["3.0-rc.0"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be able to support meteor 2.12 too I think - would need to double check when we have the CI running
if (!this.collection) { | ||
throw new Meteor.Error( | ||
`We could not find the collection instance by name: "${ | ||
this.collectionName | ||
}", the cursor description was: ${JSON.stringify( | ||
cursorDescription | ||
)}` | ||
); | ||
} | ||
|
||
// Here we apply the logic of changing the cursor based on the collection-level configuration | ||
if (this.collection._redisOplog) { | ||
const { cursor } = this.collection._redisOplog; | ||
if (cursor) { | ||
const context = DDP._CurrentPublicationInvocation.get(); | ||
cursor.call( | ||
context, | ||
cursorDescription.options, | ||
cursorDescription.selector | ||
); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove these checks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were moved to an init
function, we just removed from the constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the prettier settings to be more inline with the current setup.
@@ -0,0 +1,6 @@ | |||
{ | |||
"semi": true, | |||
"singleQuote": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be true to reduce the number of prettier changes and make it easier to review.
@matheusccastroo any progress on this? As per request I will release this as rc.2 for people's testing. |
Hi!
This PR goal is to have a version that is compatible with Meteor 3.
Closes #395