fix: link colours in timeline not showing #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
remove random console.logs also check if toFetch is not empty before fetching |
|
all done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds back support for legacy link colours by fetching profile data on the timeline and caching it in order to prevent rate limits. once a user has appeared on the timeline once, their colour (or lack thereof) is stored forever, and an XHR call will not be performed for them ever again. this works because you can't change your legacy link colour anymore.
it also increases the scroll height from the bottom required to trigger new tweets to appear. this change was done in order to mask the newfound latency in fetching user data and asynchronous extension storage reads, and fixes a bug where colours weren't fetched when the "Load more" button is clicked.