fix some window title stuff ("Sandbox" and "0") #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #930 and fixes the window title sometimes having "(0)" at the beginning (0 notifications)
for the "Sandbox" fix, i can't Exactly figure out what is causing it but it happens because of iframe navigation setting the window title to the solver frame's title, and this only seems to happen when "about:blank" is what the iframe navigation sees as the current
window.location(but i still have no idea why this causes the "Sandbox" bug, i don't understand any of the code i've tread in)for the "0" fix, i just check if unreads are more than zero before setting the cosmetic stuff