Upgrade develop to v14.3.1
#19
Conversation
jwallwork23
force-pushed
the
jwallwork23/giss-gc-14-rebased
branch
from
fb1270e to
16597f5
Compare
…native chemistry operator. These changes are likely robust.
This purposely breaks the GCClassic code, and is meant to try to get a working code, so we can go back to the prior commit with a new branch to create a version that preserves the existing GCClassic code.
There was a problem hiding this comment.
These changes were already approved as part of #3.
There was a problem hiding this comment.
These changes were already approved as part of #3.
There was a problem hiding this comment.
These changes were already approved as part of #3.
There was a problem hiding this comment.
These changes were already approved as part of #3.
jwallwork23
force-pushed
the
jwallwork23/giss-gc-14-rebased
branch
from
4a0e8c6 to
53694dc
Compare
There was a problem hiding this comment.
There are several TODOs in this file but I think it'd be fine to follow them up in subsequent issues.
|
I think this is pretty much good to go but let's discuss this in the meeting next week. Feel free to leave comments in the meantime. |
Setup continuous integration testing
| ! Indices to radiatively active species | ||
| INTEGER :: i_H2O = 0 | ||
| INTEGER :: i_CO2 = 0 | ||
| INTEGER :: i_O3 = 0 | ||
| INTEGER :: i_O2 = 0 | ||
| INTEGER :: i_NO2 = 0 | ||
| INTEGER :: i_N2O = 0 | ||
| INTEGER :: i_CH4 = 0 | ||
| INTEGER :: i_CFC11 = 0 | ||
| INTEGER :: i_CFC12 = 0 | ||
| INTEGER :: i_N2 = 0 | ||
| INTEGER :: i_CFCY = 0 | ||
| INTEGER :: i_CFCZ = 0 | ||
| INTEGER :: i_SO2 = 0 | ||
| INTEGER :: i_SO4 = 0 | ||
| INTEGER :: i_NIT = 0 | ||
| INTEGER :: i_OCPI = 0 | ||
| INTEGER :: i_OCPO = 0 | ||
| INTEGER :: i_BCPI = 0 | ||
| INTEGER :: i_BCPO = 0 | ||
| INTEGER :: i_SOAS = 0 |
There was a problem hiding this comment.
This is a change versus the previous implementation rather than GISS modelE itself.
| use CLOUDS_COM, only : pficu, pflcu, pfilsan, pfllsan | ||
| use CLOUDS_COM, only : dtrain, dqrcu, dqrlsan, reevapcn, reevapls, cmfmc |
There was a problem hiding this comment.
This is to make these available to GEOS-Chem whilst avoiding a recursive dependency.
| #ifdef TRACERS_GC | ||
| k = k + 1 | ||
| catshapes(k) = 'aijlh'; categories(k) = 'taijlh' | ||
| input_sizes3(k) = lm | ||
| call tijlh_defs(diaglists(1,k),nmax_possible,diaglens(k)) | ||
| #endif |
There was a problem hiding this comment.
Adds the ability to have GEOS-Chem tracers outputted at hourly timescales.
Backbone for how to translate #23.
There was a problem hiding this comment.
This is the interface itself based on variables defined in CHEM_COM.
There was a problem hiding this comment.
It mimics main.F90 to have GEOS-Chem as a CTM.
| @@ -267,9 +271,10 @@ SUBROUTINE DO_CHEM | |||
| State_Met%LAI (II,JJ) = lai_save(i,j) | |||
|
|
|||
| ! Land/water/ice indices [1] | |||
| State_Met%LWI (II,JJ) = 1 | |||
There was a problem hiding this comment.
LWI = land, water, ice. (1, 0, 2 resp.)
Closes #17.
Linked PRs:
fetch4/geos-chem#5
fetch4/HEMCO#3
Second attempt at #18 using a rebased version of the
dev/giss-gc-14branch.