Various fixes required on CSD3 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
force-pushed
the
csd3-fixes
branch
2 times, most recently
from
b8e54a3 to
bab8c2e
Compare
jwallwork23
force-pushed
the
csd3-fixes
branch
from
0afa465 to
4d3605d
Compare
jwallwork23
commented
Sep 16, 2024
Comment on lines
+46
to
+52
|
|
||
| # Check for later versions of the Intel compiler which have a different pattern | ||
| # for --version | ||
| ifeq ($(VER_MAJOR),for) | ||
| LIBS += -lmpifort -lmpi | ||
| # Check for some other versions | ||
| else ifneq (,$(filter 7 8 9 10,$(VER_MINOR))$(filter 2 3 4,$(VER_MAJOR))) |
There was a problem hiding this comment.
Perhaps we could reuse these version switches in the config/compiler.intel.mk edit above.
ltmurray
approved these changes
Sep 16, 2024
|
Thanks @ltmurray. @AdelekeBankole this means you can now use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst trying to get GISS-GC working on the CSD3 platform at Cambridge, I've come across several issues. The ones that should be merged back into the code are included here. Other more "hacky" fixes and debug prints can be found on the csd3-debug branch.
Some of the changes are due to the fact I am using a recent Intel compiler.