Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MODEL_GISS rather than MODEL_CLASSIC #45

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Use MODEL_GISS rather than MODEL_CLASSIC #45

merged 2 commits into from
Oct 28, 2024

Conversation

jwallwork23
Copy link
Collaborator

@jwallwork23 jwallwork23 commented Oct 23, 2024

Closes #44.

This PR updates the GISS-GC develop branch so that it builds under the MODEL_GISS compiler option rather than MODEL_CLASSIC, as was used in earlier drafts. This means we can drop several GEOS-Chem edits - see linked GEOS-Chem PR: fetch4/geos-chem#10.

Note to reviewer: please review this PR and fetch4/geos-chem#10 together.

@jwallwork23 jwallwork23 added the bug Something isn't working label Oct 23, 2024
@jwallwork23 jwallwork23 self-assigned this Oct 23, 2024
@jwallwork23 jwallwork23 requested a review from ltmurray October 23, 2024 10:15
@jwallwork23 jwallwork23 merged commit f193402 into develop Oct 28, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the model_giss branch October 28, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants