Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test integral variant for Regge/HHJ #3839

Merged
merged 12 commits into from
Nov 19, 2024
Merged

Test integral variant for Regge/HHJ #3839

merged 12 commits into from
Nov 19, 2024

Conversation

pbrubeck
Copy link
Contributor

Description

@pbrubeck pbrubeck marked this pull request as draft October 24, 2024 14:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8099 ran6518 passed1581 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8105 ran7316 passed789 skipped0 failed

pbrubeck
pbrubeck commented Oct 24, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@pbrubeck pbrubeck force-pushed the pbrubeck/test/integral-reg-hhj branch from 28b0f36 to 2888162 Compare October 25, 2024 11:15
@pbrubeck pbrubeck changed the title DO NOT MERGE Test integral variant for Regge/HHJ Oct 25, 2024
@pbrubeck pbrubeck marked this pull request as ready for review October 25, 2024 12:35
@pbrubeck pbrubeck enabled auto-merge (squash) November 19, 2024 21:55
rckirby
rckirby requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good. Just a couple of questions.

tests/regression/test_interpolate_cross_mesh.py Show resolved Hide resolved
tests/regression/test_tensor_elements.py Show resolved Hide resolved
@pbrubeck pbrubeck merged commit 3053928 into master Nov 19, 2024
12 checks passed
@pbrubeck pbrubeck deleted the pbrubeck/test/integral-reg-hhj branch November 19, 2024 23:51
connorjward pushed a commit that referenced this pull request Nov 25, 2024
@pbrubeck @connorjward
Test integral variant for Regge/HHJ (#3839)
347e717 
* DO NOT MERGE

* Test VOM with point variant

* Update .github/workflows/build.yml

* Test Regge point variant

* add continuity test

* Test H(curl div) element (#3843)

* Test H(curl div) element

* test Hu-Zhang

* checkout ufl master branch

* checkout master branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rckirby rckirby rckirby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbrubeck @rckirby